Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Incorporate internal and external discussion feedback. #32

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Incorporate internal and external discussion feedback. #32

merged 6 commits into from
Oct 14, 2019

Conversation

nkrishnaswami
Copy link
Contributor

@nkrishnaswami nkrishnaswami commented Sep 6, 2019 •
edited
Loading

This PR fixes #10

  • changes the terminology for instances of "StatisticalAnnotation" from "footnotes" to "annotations"
  • adds a "footnote" PropertyValue property to a number of types
  • adds a parent hierarchy mechanism for dimensions and their values
  • adds a brief discussion of how to configure the JSON-LD context to permit use of JSON maps instead of arrays.

@nkrishnaswami nkrishnaswami self-assigned this Sep 6, 2019
@nkrishnaswami nkrishnaswami changed the title Add links for providing feedback Incorporate internal and external discussion feedback. Oct 1, 2019
@nkrishnaswami
Copy link
Contributor Author

Renamed parentValue to parent per Omar's comment

@nkrishnaswami nkrishnaswami merged commit 0f672dd into google:master Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjelloun benjelloun Awaiting requested review from benjelloun

Assignees

@nkrishnaswami nkrishnaswami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nested/hierarchical dimensions
1 participant
@nkrishnaswami