Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: Day 1 Translations #1318

Merged
merged 1 commit into from
Oct 9, 2023
Merged

zh-CN: Day 1 Translations #1318

merged 1 commit into from
Oct 9, 2023

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Oct 6, 2023

Professional translations for missing day 1 entries #324

Professional translations for missing day 1 entries google#324
@henrif75
Copy link
Collaborator Author

henrif75 commented Oct 6, 2023

This is a new attempt, after fixing the original .po file (#1312).
The diff is large mostly because of the normalization (line breaks, etc.)

@SwiftSIQI
Copy link
Collaborator

Hi @henrif75 I made my id into the CODEOWNERS file, but I still can't review this pr?
what should i do next ?

@henrif75
Copy link
Collaborator Author

henrif75 commented Oct 8, 2023

Hi @henrif75 I made my id into the CODEOWNERS file, but I still can't review this pr? what should i do next ?

Hi @SketchK You should have received an invitation email from GitHub. Once you accept it, you should be able to review and approve PRs.
Thanks!

@SwiftSIQI SwiftSIQI self-requested a review October 8, 2023 23:24
@SwiftSIQI SwiftSIQI merged commit fdae99c into google:main Oct 9, 2023
30 checks passed
@henrif75
Copy link
Collaborator Author

Thanks!

@henrif75 henrif75 deleted the zh-CN_day1 branch October 10, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants