-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use demangled name for BuiltinWithGenericPointer #1344
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
It would be great to add the simple example you gave in the issue. Maybe just running clang front-end as in https://github.com/google/clspv/blob/main/test/emit_ir.cl#L1 |
If I add the
And passes with the PR changes. I think it should be good enough? |
We don't like adding a test without explicit checks. It makes it quite complicated sometimes when it starts failing for whatever reason to know what the test was expecting to check. As it's the link that is failing and it is performed after the GenerateIRFile, it makes sense that it does not work with |
Mh I've tried that and it seems like clspv crashes before being able to dump anything to the file... |
Without the fix, it should crash before anything is dumped. Am I missing something? |
Ah ok I misunderstood your previous comment. I thought you wanted the test to fail through FileCheck and I assumed that flag would output something I could act upon without crashing the compiler. Updated. Let me know if that's ok :) |
Co-authored-by: Romaric Jodin <[email protected]>
This tries to address #1343
@rjodinchr should I also add a test?