Update LLVM #1336
Merged
Update LLVM #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dneto0
reviewed
Apr 19, 2024
| @@ -126,7 +126,10 @@ PreservedAnalyses clspv::UndoByvalPass::run(Module &M, | |||
| // Update caller site. | |||
| for (auto User : Users) { | |||
| // Create new call instruction for new function without byval. | |||
| CallInst *Call = cast<CallInst>(User); | |||
| CallInst *Call = dyn_cast<CallInst>(User); | |||
There was a problem hiding this comment.
Yeah, it seems weird to have uses of the function F that aren't calls. But certainly we're only replacing the calls here, so it's fine to skip. Otherwise the code asserts out anyway.
But I'm curious about whether the test suite actually exercises this case. And if something does use F, what happens on the erase-from-parent down on line 157?
dneto0
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.