Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update LLVM & rework runOnUpgradeableConstantCasts #1297

Merged
merged 2 commits into from
Feb 1, 2024
Merged

update LLVM & rework runOnUpgradeableConstantCasts #1297

merged 2 commits into from
Feb 1, 2024

Conversation

rjodinchr
Copy link
Collaborator

  • fix GetIdxsForTyFromOffset when called on unsized types
  • rework runOnUpgradeableConstantCasts to be more versatile/general
  • add a case in runOnImplicitGEP for implicit cast between clspvResourceOrLocal and GEP
  • fix runOnAllocaNotAliasing to avoid lowering alloca that do not need to be lowered
  • Update tests
  • Some tests need more work and are marked FAIL

Ref #1292

@rjodinchr
update LLVM & rework runOnUpgradeableConstantCasts
9f9ed71 
- fix GetIdxsForTyFromOffset when called on unsized types
- rework runOnUpgradeableConstantCasts to be more versatile/general
- add a case in runOnImplicitGEP for implicit cast between
  clspvResourceOrLocal and GEP
- fix runOnAllocaNotAliasing to avoid lowering alloca that do not need
  to be lowered
- Update tests
- Some tests need more work and are marked FAIL

Ref google#1292
alan-baker
alan-baker approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

test/HalfStorage/clspv_vloada_half2_private.cl Outdated Show resolved Hide resolved
test/HalfStorage/vloada_half2_global.cl Show resolved Hide resolved
test/PointerCasts/multiple_implcit_casts.ll Outdated Show resolved Hide resolved
test/VariablePointers/select_wg.cl Outdated Show resolved Hide resolved
@rjodinchr rjodinchr merged commit bef237b into google:main Feb 1, 2024
1 check passed
@rjodinchr rjodinchr deleted the pr/update-llvm branch February 1, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjodinchr @alan-baker @kokoro-team