fix GetIdxsForTyFromOffset with local type #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both resource and local type start with array of zero element. Also fix the startIdx for those as the "empty" array will be removed by the rework of the type getting rid of it.
alan-baker
approved these changes
Jan 30, 2024
lib/BitcastUtils.cpp
Outdated
Comment on lines
1276
to
1279
| Idxs.push_back(ConstantInt::get(Builder.getInt32Ty(), 0)); | ||
| startIdx = 1; | ||
| if (!(SrcTy->isArrayTy() && GetNumEle(SrcTy) == 0)) { | ||
| startIdx = 1; | ||
| } |
There was a problem hiding this comment.
This probably deserves a comment and perhaps helper method IsUnsizedType(). Alternatively it might be clearer to break this in a global variable and alloca case and then a resource (global or local) case and mention that interfaces use unsized arrays again.
alan-baker
approved these changes
Jan 31, 2024
|
Ref #1292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both resource and local type start with array of zero element. Also fix the startIdx for those as the "empty" array will be removed by the rework of the type getting rid of it.