Sets cost estimation and tracking options #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce library-based options for cost estimation and cost tracking
Breaking change - This change introduced a minor shift to ensure that all instances
of the
interpreter.CostTracker
were instantiated usinginterpreter.NewCostTracker()
.This change revealed a bug where presence test,
has()
, costs were not being countedwhen calling
ContextEval()
orEval()
with state tracking enabled. This bug has beenfixed, but revealed an inconsistency in expectations between the two method calls.
Note, these options only match against type-checked expressions. This is the
same behavior as is used internally within estimators; however, it is probably
worth indicating the cost estimates are only accurate against type-checked
expressions at a future date.