Open the ASTValidator API to external authors #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12dbcd4
to
b45447a
Compare
jcking
reviewed
Jul 11, 2023
l46kok
reviewed
Jul 11, 2023
l46kok
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the private interface method from the
ASTValidatorAlso, introduce a
ValidatorConfigwhich is computed prior to callingValidate.The
ValidatorConfigallows validators to interact with each other. Currently, tointeract with another validator's configuration, the user must also implement the
ASTValidatorinterface as well. These concerns may be separated in the future.