Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators using navigable expr pattern #762

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Validators using navigable expr pattern #762

merged 2 commits into from
Jul 7, 2023

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Jun 30, 2023 •
edited
Loading

Expression Navigation utilities for querying the expression graph

#359, #420, #496, #655

@TristonianJones TristonianJones mentioned this pull request Jun 30, 2023
Open
3 tasks
@TristonianJones TristonianJones force-pushed the ast-traverse branch 4 times, most recently from 5e18455 to 7bf7071 Compare July 5, 2023 23:54
@TristonianJones TristonianJones marked this pull request as ready for review July 5, 2023 23:56
@TristonianJones TristonianJones mentioned this pull request Jul 6, 2023
Merged
l46kok
l46kok reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@l46kok l46kok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor things

common/ast/ast_test.go Show resolved Hide resolved
common/ast/expr.go Show resolved Hide resolved
common/ast/expr.go Outdated Show resolved Hide resolved
common/ast/expr.go Outdated Show resolved Hide resolved
common/ast/expr.go Outdated Show resolved Hide resolved
common/ast/expr.go Show resolved Hide resolved
@TristonianJones
Copy link
Collaborator Author

PTAL

@TristonianJones TristonianJones merged commit 5dc9173 into google:master Jul 7, 2023
2 checks passed
@TristonianJones TristonianJones deleted the ast-traverse branch July 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46kok l46kok l46kok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TristonianJones @l46kok