Migrate type-checker to native types and declarations #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the type-checker to native types and declarations
This change simplifies the internals of the type-checker considerably by relying
on function overload collision checks to happen within the
decls.FunctionDecl
instances on
Merge
. Additionally, the native types have replaced the protobuftype declarations used throughout the checker previously.
The files with the most non-trivial changes are the
checker/checker.go
andchecker/types.go
. When reviewing the code, please consider these changescarefully.
Only one location continues to use the proto-based
exprbp.Type
, and that'sthe
ref.TypeProvider
which will be updated in a follow-up PR to complete#568