Make decls/type.go equivalent to existing type singletons #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing type singletons in the
common/typespackage are used extensively within CEL and by CEL applications,so preserving their existing behavior and interfaces (
ref.Type,ref.Val) is critical when considering a consolidation of the type reps within CEL.To this effect, the
common/decls/types.gohave been updated to mirror the semantics and interfaces of the existing type singletons with a test to demonstrate parity of behavior. The next PR will migratetypes.gofromcommon/declstocommon/typesand replace the existing type singletons. This may minorly break users as the type name will switch fromtypes.TypeValuetotypes.Type. The disruption is expected to be minor as these changes are largely hidden behind thecel.Typealias.#568