Unify overflow checking in operators, field setting #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
commented
Sep 2, 2021
| } | ||
|
|
||
| // Nanoseconds cannot overflow as time.Time normalizes them to [0, 999999999]. | ||
| nsec := nsec1 - nsec2 | ||
|
|
||
| // We need to normalize nanoseconds to be positive and carry extra nanoseconds to seconds. |
There was a problem hiding this comment.
Note, the nanos are properly normalized in this case, so the logic ported from time.Unix was redundant and removed.
TristonianJones
commented
Sep 2, 2021
| @@ -127,17 +126,17 @@ func (d Double) ConvertToNative(typeDesc reflect.Type) (interface{}, error) { | |||
| func (d Double) ConvertToType(typeVal ref.Type) ref.Val { | |||
| switch typeVal { | |||
| case IntType: | |||
| i := math.Round(float64(d)) | |||
There was a problem hiding this comment.
The removal of the rounding behavior on conversion is expected and part of a cel-spec update.
89776ff
to
89b880d
Compare
jcking
reviewed
Sep 18, 2021
a094760
to
e277d68
Compare
jcking
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates additional overflow checks into
overflow.goand ensures they are applied consistently when setting object field values.There are some extensive test refactors and an update to the latest version of cel-spec v0.6.0 as well to ensure that the new code paths are being exercised and that the changes adhere to the spec. As part of this change, a small set of conformance tests now check for value truncation (rather than rounding) when converting from floating point to integer values. Given that the fixes for the incoming spec behavior were small, the truncation change was also made as part of this PR.