Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expression size limit to parser #433

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Add expression size limit to parser #433

merged 1 commit into from
Apr 16, 2021

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Apr 16, 2021

No description provided.

TristonianJones
TristonianJones requested changes Apr 16, 2021
View reviewed changes
parser/options.go Outdated Show resolved Hide resolved
parser/parser.go Outdated Show resolved Hide resolved
parser/parser_test.go Show resolved Hide resolved
TristonianJones
TristonianJones approved these changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@TristonianJones TristonianJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could just address the cosmetic changes in the test error messages, the rest looks ready to submit.

@jcking jcking merged commit 75c4c3f into google:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristonianJones TristonianJones TristonianJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcking @TristonianJones