Implement Docker #343
Open
Implement Docker #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Signed the CLA |
polarathene
suggested changes
Sep 7, 2024
| @@ -0,0 +1,18 @@ | |||
| FROM alpine:latest AS build | |||
|
|
|||
| RUN apk update && apk add git cmake build-base zlib-dev | |||
There was a problem hiding this comment.
Suggested change
| RUN apk update && apk add git cmake build-base zlib-dev | |
| RUN apk add --no-cache git cmake build-base zlib-dev |
Comment on lines
+4
to
+6
| WORKDIR /bloaty | ||
| RUN git clone https://github.com/google/bloaty.git | ||
| WORKDIR /bloaty/bloaty |
There was a problem hiding this comment.
Suggested change
| WORKDIR /bloaty | |
| RUN git clone https://github.com/google/bloaty.git | |
| WORKDIR /bloaty/bloaty | |
| WORKDIR /bloaty | |
| RUN git clone --depth=1 https://github.com/google/bloaty.git . |
Comment on lines
+9
to
+11
| FROM alpine:latest | ||
|
|
||
| RUN apk update && apk add libstdc++ libgcc |
There was a problem hiding this comment.
Suggested change
| FROM alpine:latest | |
| RUN apk update && apk add libstdc++ libgcc | |
| FROM alpine:latest | |
| RUN apk add --no-cache libstdc++ libgcc |
|
|
||
| RUN apk update && apk add libstdc++ libgcc | ||
|
|
||
| COPY --from=build /bloaty/bloaty/build/bloaty /usr/local/bin/bloaty |
There was a problem hiding this comment.
Suggested change
| COPY --from=build /bloaty/bloaty/build/bloaty /usr/local/bin/bloaty | |
| COPY --link --from=build /bloaty/build/bloaty /usr/local/bin/bloaty |
| WORKDIR /bloaty | ||
| RUN git clone https://github.com/google/bloaty.git | ||
| WORKDIR /bloaty/bloaty | ||
| RUN cmake -B build -S . && cmake --build build && cmake --build build --target install |
There was a problem hiding this comment.
Suggested change
| RUN cmake -B build -S . && cmake --build build && cmake --build build --target install | |
| RUN cmake -B build -S . \ | |
| && cmake --build build \ | |
| && cmake --build build --target install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a Dockerfile for this. Minimal image, only 53MB!