Enable Large-file Support #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm not sure how necessary this is (see my comment on #1725 ) but if we do need it please also add these definitions to the bazel build. |
This should fix google#1725
dmah42
previously approved these changes
Jan 4, 2024
|
i don't know what the pre-commit failure means or why it's an issue that the bazel file has changed in an expected way. maybe do what it says ( perhaps some file is being generated based on the BUILD.bazel? |
|
Looks like I accidentally use tabs instead of whitespaces as indent. It should be fixed now. |
dmah42
approved these changes
Jan 4, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1725