Skip to content

Commit

Permalink
Replace issue ids post migration to new issue tracker
Browse files Browse the repository at this point in the history
This change replaces anglebug.com/NNNN links.

Bug: None
Change-Id: I8ac3aec8d2a8a844b3d7b99fc0a6b2be8da31761
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637912
Reviewed-by: Geoff Lang <[email protected]>
Commit-Queue: Shahbaz Youssefi <[email protected]>
  • Loading branch information
ShabbyX authored and Angle LUCI CQ committed Jun 18, 2024
1 parent 10a98f4 commit d193d51
Show file tree
Hide file tree
Showing 299 changed files with 1,894 additions and 1,865 deletions.
6 changes: 3 additions & 3 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ config("shared_library_public_config") {
# From //build/config/mac/BUILD.gn, this is only added for
# component builds. However, since ANGLE always dynamically
# links to libvulkan, it should be re-added for non-component
# builds. (anglebug.com/4455)
# builds. (anglebug.com/42263076)
"-Wl,-rpath,@loader_path/.",
]
}
Expand Down Expand Up @@ -1458,7 +1458,7 @@ template("angle_libGLESv2") {
"src/libGLESv2/proc_table_glx_autogen.cpp",
]
} else {
#TODO(http:https://anglebug.com/7533): Add CGL entry points for mac support
#TODO(http:https://anglebug.com/42266001): Add CGL entry points for mac support
}
}

Expand Down Expand Up @@ -1543,7 +1543,7 @@ angle_static_library("libGLESv2_static") {
"src/libGLESv2/proc_table_glx_autogen.cpp",
]
} else {
#TODO(http:https://anglebug.com/7533): Add CGL entry points for mac support
#TODO(http:https://anglebug.com/42266001): Add CGL entry points for mac support
}
}
if (angle_enable_cl) {
Expand Down
2 changes: 1 addition & 1 deletion build_overrides/build.gni
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ if (is_win) {
# concerns for standalone ANGLE builds are not relevant on Windows.
enable_safe_libcxx = true
} else if (is_linux) {
# https://anglebug.com/8040: turning off safe_libcxx breaks TSAN
# https://anglebug.com/40096878: turning off safe_libcxx breaks TSAN
enable_safe_libcxx = true
} else {
enable_safe_libcxx = false
Expand Down
2 changes: 1 addition & 1 deletion doc/AddingExtensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This page describes how to add new extensions to ANGLE.

# Adding EGL extensions

Note: see also [anglebug.com/2621](http:https://anglebug.com/2621), linked
Note: see also [anglebug.com/42261334](http:https://anglebug.com/42261334), linked
from the [starter project](Starter-Projects.md) doc, to simplify some
of these steps.

Expand Down
6 changes: 3 additions & 3 deletions doc/ES1Status.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ ANGLE passes GLES1's `MustPass`, however there are known missing features.
| [Two-sided lighting][lighting] | Unimplemented | None |
| [Matrix palette][matrix] | Unimplemented (optional) | None |

[lines]: http:https://anglebug.com/7950
[lighting]: http:https://anglebug.com/7702
[matrix]: http:https://anglebug.com/7951
[lines]: http:https://anglebug.com/42266418
[lighting]: http:https://anglebug.com/42266170
[matrix]: http:https://anglebug.com/42266419

### Notes [1]
* Logic op is implemented through the `ANGLE_logic_op` or `EXT_framebuffer_fetch` extensions.
Expand Down
4 changes: 2 additions & 2 deletions doc/ES31StatusOnD3D11.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
* Images in non-compute shaders are not implemented yet.
* Multiple image variables are not allowed to be bound to the same image unit which refers to the same layer and level of a texture image. It means image aliasing is not supported.
* The same layer and level of a texture are not allowed to be bound to multiple image units.
* When a texture is bound to an image unit, the image unit format must exactly match the texture internal format. Similarly, the format layout qualifier for an image variable must exactly match the format of the image unit. Re-interpretation is not supported. See [here](http:https://anglebug.com/3038).
* When a texture is bound to an image unit, the image unit format must exactly match the texture internal format. Similarly, the format layout qualifier for an image variable must exactly match the format of the image unit. Re-interpretation is not supported. See [here](http:https://anglebug.com/42261723).

### Notes [2]
* Shader storage blocks in non-compute shaders are not implemented yet.
* Multiple shader storage blocks are not allowed to be bound to the same buffer. See [here](http:https://anglebug.com/3032).
* Multiple shader storage blocks are not allowed to be bound to the same buffer. See [here](http:https://anglebug.com/42261718).
8 changes: 4 additions & 4 deletions gni/angle.gni
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ declare_args() {

declare_args() {
# Expose WGL entry points, which is necessary for running windows desktop GL applications against ANGLE.
# TODO(http:https://anglebug.com/7628): This condition should be `angle_enable_gl_desktop_frontend && is_win`
# TODO(http:https://anglebug.com/42266094): This condition should be `angle_enable_gl_desktop_frontend && is_win`
# This is disabled by default on Windows because it was causing some test failures. Once the WGL frontend
# has more functionality implemented, we can re-enable this.
angle_expose_wgl_entry_points = false
Expand Down Expand Up @@ -145,7 +145,7 @@ declare_args() {
(angle_64bit_current_cpu && android64_ndk_api_level >= 26)
}

# Vulkan loader is statically linked on Mac. http:https://anglebug.com/4477
# Vulkan loader is statically linked on Mac. http:https://anglebug.com/40096682
angle_shared_libvulkan = !is_mac

# There's no "is_winuwp" helper in BUILDCONFIG.gn, so we define one ourselves
Expand Down Expand Up @@ -201,15 +201,15 @@ declare_args() {
angle_enable_null = !is_official_build
angle_enable_gl_desktop_backend = !is_android && !is_ios

# http:https://anglebug.com/2634
# http:https://anglebug.com/40096506
angle_enable_metal = is_apple

# Enables the OpenCL pass-through back end
angle_enable_cl_passthrough = angle_enable_cl

# Disable WGPU backend.
# Currently disabled on Android, Fuschia, WinUWP, and Win MSVC.
# anglebug.com/8541
# anglebug.com/42266968
angle_enable_wgpu =
!is_official_build && !(is_android || is_fuchsia || angle_is_winuwp) &&
(!is_win || is_clang) && defined(angle_dawn_dir)
Expand Down
14 changes: 7 additions & 7 deletions include/GLSLANG/ShaderLang.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

// Version number for shader translation API.
// It is incremented every time the API changes.
#define ANGLE_SH_VERSION 354
#define ANGLE_SH_VERSION 355

enum ShShaderSpec
{
Expand Down Expand Up @@ -138,8 +138,8 @@ struct ShPixelLocalStorageOptions
// Or do we need to manually pack and unpack from r32i/r32ui?
bool supportsNativeRGBA8ImageFormats = false;

// anglebug.com/7792 -- Metal [[raster_order_group()]] does not work for read_write textures on
// AMD when the render pass doesn't have a color attachment on slot 0. To work around this we
// anglebug.com/42266263 -- Metal [[raster_order_group()]] does not work for read_write textures
// on AMD when the render pass doesn't have a color attachment on slot 0. To work around this we
// attach one of the PLS textures to GL_COLOR_ATTACHMENT0, if there isn't one already.
bool renderPassNeedsAMDRasterOrderGroupsWorkaround = false;
};
Expand Down Expand Up @@ -342,7 +342,7 @@ struct ShCompileOptions
// targeted to workaround a bug in NVIDIA D3D driver where the return value from
// RWByteAddressBuffer.InterlockedAdd does not get resolved when used in the .yzw components of
// a RWByteAddressBuffer.Store operation. Only has an effect on HLSL translation.
// http:https://anglebug.com/3246
// http:https://anglebug.com/42261924
uint64_t forceAtomicValueResolution : 1;

// Rewrite gl_BaseVertex and gl_BaseInstance as uniform int
Expand Down Expand Up @@ -421,9 +421,9 @@ struct ShCompileOptions
// causing the comparison to fail.
uint64_t castMediumpFloatTo16Bit : 1;

// anglebug.com/7527: packUnorm4x8 fails on Pixel 4 if it is not passed a highp vec4.
// TODO(anglebug.com/7527): This workaround is currently only applied for pixel local storage.
// We may want to apply it generally.
// anglebug.com/42265995: packUnorm4x8 fails on Pixel 4 if it is not passed a highp vec4.
// TODO(anglebug.com/42265995): This workaround is currently only applied for pixel local
// storage. We may want to apply it generally.
uint64_t passHighpToPackUnormSnormBuiltins : 1;

// Use an integer uniform to pass a bitset of enabled clip distances.
Expand Down
2 changes: 1 addition & 1 deletion include/GLSLANG/ShaderVars.h
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ struct ShaderVariable
int flattenedOffsetInParentArrays;
};

// TODO: anglebug.com/3899
// TODO: anglebug.com/42262544
// For backwards compatibility for other codebases (e.g., chromium/src/gpu/command_buffer/service)
using Uniform = ShaderVariable;
using Attribute = ShaderVariable;
Expand Down
2 changes: 1 addition & 1 deletion include/angle_gl.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "GLES3/gl31.h"
#include "GLES3/gl32.h"

// TODO(http:https://anglebug.com/3730): Autogenerate these enums from gl.xml
// TODO(http:https://anglebug.com/42262388): Autogenerate these enums from gl.xml
// HACK: Defines for queries that are not in GLES
#define GL_CONTEXT_PROFILE_MASK 0x9126
#define GL_CONTEXT_COMPATIBILITY_PROFILE_BIT 0x00000002
Expand Down
10 changes: 5 additions & 5 deletions include/platform/autogen/FeaturesD3D_autogen.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ struct FeaturesD3D : FeatureSetBase
FeatureCategory::D3DWorkarounds,
"Bug in some drivers triggers a TDR when using CopySubresourceRegion from a staging "
"texture to a depth/stencil",
&members, "http:https://anglebug.com/1452"
&members, "http:https://anglebug.com/40096371"
};

FeatureInfo expandIntegerPowExpressions = {
Expand Down Expand Up @@ -150,7 +150,7 @@ struct FeaturesD3D : FeatureSetBase
"addMockTextureNoRenderTarget",
FeatureCategory::D3DWorkarounds,
"On some drivers when rendering with no render target, two bugs lead to incorrect behavior",
&members, "http:https://anglebug.com/2152"
&members, "http:https://anglebug.com/40644627"
};

FeatureInfo skipVSConstantRegisterZero = {
Expand All @@ -165,7 +165,7 @@ struct FeaturesD3D : FeatureSetBase
FeatureCategory::D3DWorkarounds,
"On some drivers the return value from RWByteAddressBuffer.InterlockedAdd does not resolve "
"when used in the .yzw components of a RWByteAddressBuffer.Store operation",
&members, "http:https://anglebug.com/3246"
&members, "http:https://anglebug.com/42261924"
};

FeatureInfo allowClearForRobustResourceInit = {
Expand All @@ -180,7 +180,7 @@ struct FeaturesD3D : FeatureSetBase
FeatureCategory::D3DWorkarounds,
"There is a slow fxc compile performance issue with dynamic uniform indexing if "
"translating a uniform block with a large array member to cbuffer.",
&members, "http:https://anglebug.com/3682"
&members, "http:https://anglebug.com/40096608"
};

FeatureInfo allowES3OnFL100 = {
Expand All @@ -194,7 +194,7 @@ struct FeaturesD3D : FeatureSetBase
"disableRasterizerOrderViews",
FeatureCategory::D3DWorkarounds,
"Disable ROVs for testing",
&members, "http:https://anglebug.com/7279"
&members, "http:https://anglebug.com/40096838"
};

FeatureInfo enableTimestampQueries = {
Expand Down
Loading

0 comments on commit d193d51

Please sign in to comment.