Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the group id and artifact id of the workflow library #999

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Correct the group id and artifact id of the workflow library

Alternative(s) considered
NA

Type
Choose one: Releases

Screenshots (if applicable)
NA

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #999 (3c25057) into master (0e357f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #999   +/-   ##
=========================================
  Coverage     88.37%   88.37%           
  Complexity      523      523           
=========================================
  Files           112      112           
  Lines          9388     9388           
  Branches        648      648           
=========================================
  Hits           8297     8297           
  Misses          748      748           
  Partials        343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e357f5...3c25057. Read the comment docs.

Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Just a suggestion maybe to add these values for all the libraries at a common place so that its easy to look and update them in a single place/ file something similar to Dependencies.kt

@jingtang10 jingtang10 merged commit c959005 into master Jan 5, 2022
@jingtang10 jingtang10 deleted the jt/workflow-build branch January 5, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants