Modify risk-factor questionnaire. #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
=========================================
Coverage 84.47% 84.47%
Complexity 608 608
=========================================
Files 133 133
Lines 10282 10282
Branches 753 753
=========================================
Hits 8686 8686
Misses 1221 1221
Partials 375 375 Continue to review full report at Codecov.
|
santosh-pingle
requested review from
aditya-07,
deepankarb,
jingtang10,
kevinmost,
stevenckngaa and
yigit
as code owners
jingtang10
requested changes
Jan 24, 2022
done. |
jingtang10
approved these changes
Jan 25, 2022
|
@santosh-pingle , changes for the PR are approved but the branch seems to be out of sync with the base branch. Please let me know if you are blocked on merging the changes. |
ktarasenko
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Remove No Valuequantity text from patient details card. * Refactoring. * Modify risk-factors questionnaire. * spotless apply * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #859
Description
ValueCoding from answer option was mapped to the Observation.code and valueCoding for the Observation code was missing in risk-factor questionnaire.
Now, valueCoding from answerOption in questionnaire is mapped to the Observation.value, and added separate valueCoding
for observation code in risk-factors questionnaire.
Note :
As of now we have added temporary valueCoding in risk-factor question which are mapped to the Observation code, it will be replaced with real code once received.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally