Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing tests of AutoCompleteTextView for lower android versions. #972

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #970

Description
After analyzing the trace, Added @UiThreadTest to the setup for tests where the Layout was getting inflated.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #972 (d96ddd2) into master (43ccab2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #972   +/-   ##
=========================================
  Coverage     88.27%   88.27%           
  Complexity      500      500           
=========================================
  Files           113      113           
  Lines          9390     9390           
  Branches        654      654           
=========================================
  Hits           8289     8289           
  Misses          751      751           
  Partials        350      350           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ccab2...d96ddd2. Read the comment docs.

@jingtang10 jingtang10 enabled auto-merge (squash) December 15, 2021 15:23
@jingtang10 jingtang10 merged commit f2fcc8c into master Dec 16, 2021
@jingtang10 jingtang10 deleted the ak/autocomplete-instrumentationtest-fix branch December 16, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Instrumentation test fails on API level 21 with exception: android.view.InflateException
2 participants