-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the NpmPackage dependency for structure-map based resource extraction. #844
Conversation
…action down from datacapture library to the client apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aditya-07
@ekigamba FYI - we needed to remove the npm package because it bloats the library. but if the client does need to load a custom npm package they can provide it using the config. and that's a functionality (e.g. TarGzipUtility.kt
and NpmPackageProvider.kt
) that may well exist in fhir core lib. @pld FYI as well.
datacapture/src/main/java/com/google/android/fhir/datacapture/DataCaptureConfig.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/google/android/fhir/datacapture/utilities/SimpleWorkerContextProvider.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Outdated
Show resolved
Hide resolved
btw - have you noticed the size decrease before vs after this PR :) can you share the difference? |
it's already in the pr description. thanks for pointing out. |
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
============================================
+ Coverage 33.36% 33.53% +0.17%
+ Complexity 458 457 -1
============================================
Files 108 105 -3
Lines 9033 8981 -52
Branches 560 552 -8
============================================
- Hits 3014 3012 -2
+ Misses 5732 5684 -48
+ Partials 287 285 -2
Continue to review full report at Codecov.
|
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #808
Description
Moved the NpmPackage dependency for structure-map based resource extraction action down from datacapture library to the client apps. Now the onus is on the client apps to load the NpmPackage with all the resources that maybe required by the structure-map.
This has reduced the size of our Reference App from 48.8 MB to 35.6 MB,
packages.fhir.org-hl7.fhir.r4.core-4.0.1.tgz
being 12.8MB.Alternative(s) considered
No
Type
Choose one: Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project./gradlew check
and./gradlew connectedCheck
to test my changes locally