Add boolean type widget with support for error correction (unselect by tapping again)

[maanuanubhav999]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #530

Description
Added Boolean type widget which would replace checkbox type widget.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
#546

Type
Choose one:Bug fix

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct
• I have read How to Contribute
• I have read the Developer's guide
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
• I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

[codecov-commenter]

Codecov Report

Merging #781 (33c0b29) into master (1945917) will decrease coverage by 0.21%.
The diff coverage is 56.92%.

@@             Coverage Diff              @@
##             master     #781      +/-   ##
============================================
- Coverage     88.78%   88.56%   -0.22%     
- Complexity      467      469       +2     
============================================
  Files           106      107       +1     
  Lines          9095     9157      +62     
  Branches        580      611      +31     
============================================
+ Hits           8075     8110      +35     
  Misses          715      715              
- Partials        305      332      +27     

Impacted Files	Coverage Δ
...droid/fhir/datacapture/QuestionnaireItemAdapter.kt	53.62% <50.00%> (ø)
...tionnaireItemBooleanTypePickerViewHolderFactory.kt	56.45% <56.45%> (ø)
...hir/datacapture/QuestionnaireItemViewHolderType.kt	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1945917...33c0b29. Read the comment docs.

[maanuanubhav999]

Do we have to add "Not answered" even in the check box type?

I have not yet added it. Since users can unselect the check box and remove answers unlike radio groups or dropdown.
But we may add it if we want uniformity in all the choice types.

[jingtang10]

Thanks @maanuanubhav999! 👍 A couple of high-level comments:

1. Can you please remove QuestionnaireItemCheckBoxViewHolderFactory and all references to it?
2. Can you reuse QuestionnaireItemRadioGroupviewHolderFactory instead of creating a new widget type (QuestionnaireItemBooleanTypePickerViewHolderFactory)? The new widget factory you created does pretty much what the radio group does. I think the only difference is that if the question is boolean type it needs to generate two answer options true/false, and you have to translate them to the correct answers when the user answers the questions.

[jingtang10]

Do we have to add "Not answered" even in the check box type?

I have not yet added it. Since users can unselect the check box and remove answers unlike radio groups or dropdown. But we may add it if we want uniformity in all the choice types.

If you're talking about checkox group - you're right we don't need not answered option, because the user can just untick everything. If you're talking about a single checkbox - I think we should just get rid of it since there won't be any use for it (I commented in my review already).

[jingtang10]

Please also rename your PR title to something that reads better e.g. "Add 'not answered' option to radio button group and use it for boolean type questions"

[jingtang10]

HI @maanuanubhav999 -- thanks for working on this! any update on changing this to use the existing radio button group widget?

[maanuanubhav999]

Hey, @jingtang10 I will try to complete it in 2-3 days.

[jingtang10]

@shelaghm and I are discussing some alternative solutions - will update and hopefully will provide some mocks to guide implementation

[maanuanubhav999]

Okay, that would be great!

[jingtang10]

thanks so much for this - can you add a couple of screenshots for your new widget?

[jingtang10]

Thanks very much for perseverance - this should be the last round of comments.

Following the same design pattern of the yes/no radio button, I don't believe we want to add another radio button for the radio button group. I would suggest revert the changes for the radio button group and drop down and create two separate issues (and raise 2 separate PRs if you wish) for them.

[jingtang10]

move this 2 lines above

[maanuanubhav999]

Hey, didn't get this, why would we need to shift this? @jingtang10

[jingtang10]

can you move this line to the top:

val (questionnaireItem, questionnaireResponseItem) = questionnaireItemViewItem

so that the if else block can use questionnaireItem rather than questionnaireItemViewItem.questionnaireItem

also, move boolTypeHeader setup before the answer setup because that's consistent with the order of the widgets.

[maanuanubhav999]

sure, also removed answer since it was not needed anywhere.

[jingtang10]

did you push the changes addressing the comments from the previous review? i can't seem to see any.

thanks!

[jingtang10]

can you move this line to the top:

val (questionnaireItem, questionnaireResponseItem) = questionnaireItemViewItem

so that the if else block can use questionnaireItem rather than questionnaireItemViewItem.questionnaireItem

also, move boolTypeHeader setup before the answer setup because that's consistent with the order of the widgets.

[jingtang10]

Great work! Thanks @maanuanubhav999! 👍 🎉