Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix sync exceptions for failing server #708

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Conversation

maimoonak
Copy link
Collaborator

@maimoonak maimoonak commented Aug 12, 2021

Fixes #707

Description
Serialization of State exclude the exceptions now. The WorkManager does not allow emitting data more than 10240 bytes

Alternative(s) considered
No alternates. This is WorkManager constraint

Type
Choose one: (Bug fix)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #708 (92528f9) into master (fefbdd6) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head 92528f9 differs from pull request most recent head d0eeca4. Consider uploading reports for the commit d0eeca4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #708      +/-   ##
============================================
- Coverage     53.25%   53.08%   -0.18%     
- Complexity      194      195       +1     
============================================
  Files            47       47              
  Lines           969      974       +5     
  Branches        134      134              
============================================
+ Hits            516      517       +1     
- Misses          371      376       +5     
+ Partials         82       81       -1     
Impacted Files Coverage Δ
...ava/com/google/android/fhir/sync/FhirSyncWorker.kt 0.00% <0.00%> (ø)
...n/java/com/google/android/fhir/sync/SyncJobImpl.kt 0.00% <0.00%> (ø)
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 37.77% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefbdd6...d0eeca4. Read the comment docs.

@maimoonak maimoonak marked this pull request as ready for review August 12, 2021 15:11
engine/src/main/java/com/google/android/fhir/Util.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/Util.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/Util.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/Util.kt Outdated Show resolved Hide resolved
@maimoonak maimoonak merged commit 47122b2 into master Aug 17, 2021
@maimoonak maimoonak deleted the hotfix_sync_exceptions branch August 17, 2021 07:20
@Tarun-Bhardwaj Tarun-Bhardwaj added this to In progress in FHIR engine library via automation Sep 27, 2021
@Tarun-Bhardwaj Tarun-Bhardwaj added the type:bug Something isn't working label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
No open projects
FHIR engine library
  
In progress
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: Data cannot occupy more than 10240 bytes when serialized
5 participants