Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the resource_id type of the resources table in db. #7

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Correct the resource_id type of the resources table in db. #7

merged 1 commit into from
Apr 6, 2020

Conversation

jingtang10
Copy link
Collaborator

This has not caused an error due to SQLite's type affinity: https://www.sqlite.org/datatype3.html#affinity

@jingtang10 jingtang10 assigned tinagogna and githengi and unassigned tinagogna and githengi Apr 3, 2020
tinagogna
tinagogna approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@tinagogna tinagogna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, was int a mistake?

@jingtang10
Copy link
Collaborator Author

Lgtm, was int a mistake?

Yes - it didn't cause an error however because of type affinity - see link above.

Thanks.

@jingtang10 jingtang10 merged commit d8c85b4 into master Apr 6, 2020
@jingtang10 jingtang10 deleted the db-id-type branch April 6, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinagogna tinagogna tinagogna approved these changes

@githengi githengi Awaiting requested review from githengi

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jingtang10 @tinagogna @githengi