Sync - Generalizing resource downloading #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
force-pushed
the
fm/sync_prototype
branch
from
3306087
to
d5ac30b
Compare
florina-muntenescu
changed the title
florina-muntenescu
force-pushed
the
fm/sync_prototype
branch
5 times, most recently
from
a7d5b24
to
0d6fae1
Compare
jingtang10
reviewed
Jun 18, 2020
fhirengine/src/main/java/com/google/fhirengine/sync/SyncConfiguration.kt
Outdated
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/db/impl/SyncedResource.kt
Show resolved
Hide resolved
example/src/main/java/com/google/fhirengine/example/MainActivityViewModel.kt
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/sync/SyncData.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
fm/sync_prototype
branch
from
c7410af
to
40c5014
Compare
jingtang10
approved these changes
Jun 25, 2020
yigit
reviewed
Jun 25, 2020
| @@ -89,6 +90,11 @@ internal class DatabaseImpl( | |||
| } ?: throw ResourceNotFoundInDbException(type.name, id) | |||
| } | |||
|
|
|||
| // TODO implement the last update date query | |||
There was a problem hiding this comment.
do you want to merge this after implementing it or merge w/ TODO?
| // TODO find a better exception to throw | ||
| @Override | ||
| public Result sync() throws Exception { | ||
| if (syncConfiguration == null) { |
There was a problem hiding this comment.
i think illegal state is proper here. and once we move to kotlin, we can just do checkNotNull
fhirengine/src/main/java/com/google/fhirengine/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/sync/FhirSynchronizer.kt
Outdated
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/sync/ResourceSynchronizer.kt
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/sync/SyncData.kt
Outdated
Show resolved
Hide resolved
fhirengine/src/main/java/com/google/fhirengine/sync/SyncDownloadWorker.kt
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| class SyncDownloadWorkerFactory( |
There was a problem hiding this comment.
does WM accept multiple workers?
if not, we should probably receive a delegate here so that it can be combined
There was a problem hiding this comment.
I'll handle this properly as part of #71
fhirengine/src/main/java/com/google/fhirengine/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
fm/sync_prototype
branch
from
40c5014
to
f35a8be
Compare
yigit
requested changes
Jun 29, 2020
fhirengine/src/main/java/com/google/fhirengine/sync/SyncData.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.