Language switcher for the Data Capture Gallery #558

ndegwamartin · 2021-06-17T17:32:48Z

Fixes #503

Description

Adds a language switcher to the data capture gallery useful to demo internationalization in the sdc lib
Localized some widget text to Vietnamese
~~Updated to the latest translated questionnaire Questionnaire-case-reporting-questionnaire-vn.zip~~

Type
Feature

Screenshots

Checklist

I have read and acknowledged the Code of conduct
I have read How to Contribute
I have read the Developer's guide
I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

google-cla · 2021-06-17T17:32:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

ndegwamartin · 2021-06-18T06:27:27Z

@googlebot I signed it!

jingtang10 · 2021-06-24T14:00:44Z

Thanks @ndegwamartin :) This is really cool 😎

A note on UI: I'm not sure @fredhersch has any comment - but I would love to keep things simple to begin with. Do we have to have a navigation drawer on the left? Can we simply make this an action item on the top bar: number 4 in https://material.io/components/app-bars-top#anatomy?

fredhersch · 2021-06-25T01:32:02Z

Thanks @jingtang10 I had requested the drawer. I think it's the most logical way to show this for implementers and will be useful for other features (like syncing). If you have concerns about maintainability of the demo app using this approach let's revisit. Otherwise, I'd propose we go ahead with this. Looks great @ndegwamartin

jingtang10 · 2021-06-30T12:48:37Z

spoke with @fredhersch and we think the drawer layout is probably more useful for the reference app rather than the sdc gallery app here. if it's possible to refactor please do so - thanks @ndegwamartin!

ndegwamartin · 2021-07-07T09:08:35Z

The Language selection dialog now pops up when you touch the action item on the right of the top app bar.

ndegwamartin · 2021-07-07T09:11:48Z

@fredhersch @jingtang10 might be worth having the first page localised in Vietnamese so that it is apparent every time one switches the language, even before getting to the questionnaires

jingtang10

Thanks @ndegwamartin!

...ery/src/main/java/com/google/android/fhir/datacapture/gallery/utils/LanguageSwitcherUtils.kt

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

jingtang10 · 2021-07-07T13:25:59Z

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

+ language: LanguageSwitcherUtils.Language,
+ context: Activity
+ ) {
+


remove new line

this isn't done

...ery/src/main/java/com/google/android/fhir/datacapture/gallery/utils/LanguageSwitcherUtils.kt

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

...ery/src/main/java/com/google/android/fhir/datacapture/gallery/utils/LanguageSwitcherUtils.kt

Tarun-Bhardwaj · 2021-07-14T06:04:01Z

Hi @ndegwamartin , is there an ETA you can provide for completing the changes as per the review comments in order to close this PR?

ndegwamartin · 2021-07-14T10:17:59Z

Hi @ndegwamartin , is there an ETA you can provide for completing the changes as per the review comments in order to close this PR?

@Tarun-Bhardwaj all changes requested are complete

...apturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/utils/LocaleUtils.kt

ndegwamartin · 2021-07-20T05:53:44Z

@deepankarb please check out the updates

Tarun-Bhardwaj · 2021-08-07T14:28:16Z

@deepankarb , it seems Martin has completed all changes as per review comments. Could you please re-review the same?

codecov-commenter · 2021-08-26T07:32:19Z

Codecov Report

Merging #558 (c0b966c) into master (6084de7) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
+ Coverage     88.78%   88.79%   +0.01%     
  Complexity      464      464              
============================================
  Files           106      106              
  Lines          9089     9089              
  Branches        579      579              
============================================
+ Hits           8070     8071       +1     
+ Misses          714      713       -1     
  Partials        305      305

Impacted Files	Coverage Δ
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt	`85.45% <0.00%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6084de7...c0b966c. Read the comment docs.

- Add language switcher to demo internationalization in the sdc lib - Vietnamese localization

- Remove Navigation Drawer - Add language selection as an Action item

jingtang10 · 2021-11-24T16:00:56Z

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

 override fun onCreate(savedInstanceState: Bundle?) {
 super.onCreate(savedInstanceState)
 binding = ActivityMainBinding.inflate(layoutInflater)
 setContentView(binding.root)
+


remove new line

jingtang10 · 2021-11-24T16:01:12Z

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

+
+ override fun onCreateOptionsMenu(menu: Menu): Boolean {
+ menuInflater.inflate(R.menu.top_bar_menu, menu)
+


remove new line

jingtang10 · 2021-11-24T16:01:34Z

datacapturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/MainActivity.kt

 override fun onCreate(savedInstanceState: Bundle?) {
 super.onCreate(savedInstanceState)
 binding = ActivityMainBinding.inflate(layoutInflater)
 setContentView(binding.root)
+
+ languageList = LocaleUtils.getLanguageList(this)


can this line be on line 31?

jingtang10 · 2021-11-26T10:38:21Z

Following our discussion yesterday @ndegwamartin I closed this issue #503 (comment). Will you please close this PR if this sounds good to you? Thanks for the good work and I hope the learnings here have been useful in fhir core!

ndegwamartin · 2021-11-26T11:12:14Z

Following our discussion yesterday @ndegwamartin I closed this issue #503 (comment). Will you please close this PR if this sounds good to you? Thanks for the good work and I hope the learnings here have been useful in fhir core!

Yeah I've learnt a alot. Closing this now

ndegwamartin requested review from fredhersch, aditya-07 and jingtang10 June 17, 2021 17:32

ndegwamartin requested review from deepankarb, joiskash, kevinmost, pankajkatoch and yigit as code owners June 17, 2021 17:32

ndegwamartin force-pushed the mn/503-language-switcher branch from 646c736 to 4ad55ec Compare June 29, 2021 12:44

ndegwamartin requested a review from stevenckngaa as a code owner June 29, 2021 12:44

ndegwamartin force-pushed the mn/503-language-switcher branch from 4ad55ec to 101075d Compare July 7, 2021 08:47

jingtang10 requested changes Jul 7, 2021

View reviewed changes

ndegwamartin force-pushed the mn/503-language-switcher branch 4 times, most recently from 9a97cba to d9751d7 Compare July 12, 2021 10:16

Tarun-Bhardwaj assigned ndegwamartin Jul 14, 2021

Tarun-Bhardwaj requested a review from jingtang10 July 14, 2021 10:29

Tarun-Bhardwaj assigned jingtang10 and unassigned ndegwamartin Jul 14, 2021

deepankarb reviewed Jul 15, 2021

View reviewed changes

...apturegallery/src/main/java/com/google/android/fhir/datacapture/gallery/utils/LocaleUtils.kt Show resolved Hide resolved

ndegwamartin force-pushed the mn/503-language-switcher branch 2 times, most recently from 3452b6d to ca6a6a4 Compare July 26, 2021 12:11

ndegwamartin requested a review from deepankarb July 26, 2021 13:20

ndegwamartin force-pushed the mn/503-language-switcher branch from ca6a6a4 to 7dd842a Compare August 26, 2021 07:11

Tarun-Bhardwaj added this to In progress in Data capture library via automation Sep 15, 2021

ndegwamartin force-pushed the mn/503-language-switcher branch 3 times, most recently from d8c113d to 248b340 Compare November 12, 2021 07:18

ndegwamartin added 6 commits November 16, 2021 09:43

Add latest version of translated hiv case report

4c7fa24

Implement language switcher

d65430c

- Add language switcher to demo internationalization in the sdc lib - Vietnamese localization

Refactor Language Selection

da674e0

- Remove Navigation Drawer - Add language selection as an Action item

Clean up + Refactor ♻️

8fa0928

Reset openhie-hiv-case-report.json to master

67178c4

Code clean up

809b722

ndegwamartin force-pushed the mn/503-language-switcher branch from 248b340 to 809b722 Compare November 16, 2021 06:43

jingtang10 approved these changes Nov 23, 2021

View reviewed changes

Merge branch 'master' into mn/503-language-switcher

c0b966c

ndegwamartin enabled auto-merge (squash) November 23, 2021 14:20

jingtang10 self-requested a review November 23, 2021 14:57

jingtang10 approved these changes Nov 23, 2021

View reviewed changes

jingtang10 requested changes Nov 24, 2021

View reviewed changes

ndegwamartin closed this Nov 26, 2021

auto-merge was automatically disabled November 26, 2021 11:12
Pull request was closed

Data capture library automation moved this from In progress to Done Nov 26, 2021

jingtang10 deleted the mn/503-language-switcher branch April 16, 2022 12:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language switcher for the Data Capture Gallery #558

Language switcher for the Data Capture Gallery #558

ndegwamartin commented Jun 17, 2021 •

edited

Loading

google-cla bot commented Jun 17, 2021

ndegwamartin commented Jun 18, 2021

jingtang10 commented Jun 24, 2021

fredhersch commented Jun 25, 2021

jingtang10 commented Jun 30, 2021

ndegwamartin commented Jul 7, 2021

ndegwamartin commented Jul 7, 2021

jingtang10 left a comment

jingtang10 Jul 7, 2021

jingtang10 Nov 24, 2021

Tarun-Bhardwaj commented Jul 14, 2021

ndegwamartin commented Jul 14, 2021

ndegwamartin commented Jul 20, 2021

Tarun-Bhardwaj commented Aug 7, 2021

codecov-commenter commented Aug 26, 2021 •

edited by codecov bot

Loading

jingtang10 Nov 24, 2021

jingtang10 Nov 24, 2021

jingtang10 Nov 24, 2021

jingtang10 commented Nov 26, 2021 •

edited

Loading

ndegwamartin commented Nov 26, 2021


		override fun onCreateOptionsMenu(menu: Menu): Boolean {
		menuInflater.inflate(R.menu.top_bar_menu, menu)

Language switcher for the Data Capture Gallery #558

Language switcher for the Data Capture Gallery #558

Conversation

ndegwamartin commented Jun 17, 2021 • edited Loading

google-cla bot commented Jun 17, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

ndegwamartin commented Jun 18, 2021

jingtang10 commented Jun 24, 2021

fredhersch commented Jun 25, 2021

jingtang10 commented Jun 30, 2021

ndegwamartin commented Jul 7, 2021

ndegwamartin commented Jul 7, 2021

jingtang10 left a comment

Choose a reason for hiding this comment

jingtang10 Jul 7, 2021

Choose a reason for hiding this comment

jingtang10 Nov 24, 2021

Choose a reason for hiding this comment

Tarun-Bhardwaj commented Jul 14, 2021

ndegwamartin commented Jul 14, 2021

ndegwamartin commented Jul 20, 2021

Tarun-Bhardwaj commented Aug 7, 2021

codecov-commenter commented Aug 26, 2021 • edited by codecov bot Loading

Codecov Report

jingtang10 Nov 24, 2021

Choose a reason for hiding this comment

jingtang10 Nov 24, 2021

Choose a reason for hiding this comment

jingtang10 Nov 24, 2021

Choose a reason for hiding this comment

jingtang10 commented Nov 26, 2021 • edited Loading

ndegwamartin commented Nov 26, 2021

ndegwamartin commented Jun 17, 2021 •

edited

Loading

codecov-commenter commented Aug 26, 2021 •

edited by codecov bot

Loading

jingtang10 commented Nov 26, 2021 •

edited

Loading