code-health: Migrating hardcoded-strings

[Ana2k]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straighforward changes).

Fixes #379

Description
Migrate user-visible hard-coded string files

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: |Code-Health|

Screenshots (if applicable)
N/A

Checklist

• I have read and acknowledge the Code of conduct
• I have read How to Contribute
• I have read the Developer's guide
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
• I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

[Manikant25]

@Ana2k Try to run ./gradlew spotlessApply and ./gradlew spotlessCheck. I think there is a problem in the coding style.

[Ana2k]

@Ana2k Try to run ./gradlew spotlessApply and ./gradlew spotlessCheck. I think there is a problem in the coding style.

@Manikant25 thanks for the advice, its currently WIP(work-in-progress). After I complete making all the changes I will surely. Thanks :)

[epicadk]

@Ana2k Try to run ./gradlew spotlessApply and ./gradlew spotlessCheck. I think there is a problem in the coding style.

@Manikant25 thanks for the advice, its currently WIP(work-in-progress). After I complete making all the changes I will surely. Thanks :)

You can convert it to draft so people will know you are still working on it. No need to add WIP in the title.

[Ana2k]

@Ana2k Try to run ./gradlew spotlessApply and ./gradlew spotlessCheck. I think there is a problem in the coding style.

@Manikant25 thanks for the advice, its currently WIP(work-in-progress). After I complete making all the changes I will surely. Thanks :)

You can convert it to draft so people will know you are still working on it. No need to add WIP in the title.

Afaik WIP means Work In Progress, and I feel more comfortable doing this as seen in other open source orgs. Thanks for the suggestion!

[Ana2k]

@jingtang10 I have finished working on this issue. Please review pr. Thanks!

[epicadk]

Afaik WIP means Work In Progress, and I feel more comfortable doing this as seen in other open source orgs. Thanks for the suggestion!

It was suggested by one of the maintainers here. : /
#386 (comment)

[Ana2k]

Afaik WIP means Work In Progress, and I feel more comfortable doing this as seen in other open source orgs. Thanks for the suggestion!

It was suggested by one of the maintainers here. : /
#386 (comment)

Yupp saw it. Thanks! :)

[jingtang10]

1. please don't put exception strings in resource files.
2. please revert all changes in cqlreference module since the ui will change.

[jingtang10]

this is not a feature. this is code health. please update PR type and title.

[Ana2k]

1. please don't put exception strings in resource files.
2. please revert all changes in cqlreference module since the ui will change.

1. I can turn translatable as false for the exception message.
   Then I hope no issue with i10 or i18 translation will be there?
2. Should I revert the Snackbars too?(they are in cqlreference non UI part)
3. Since only minor changes are left for string and dimensions migration so I would prefer closing both the pr, and making a new pr, with those minor changes.

Please let me know your views
Thanks.

[jingtang10]

@Ana2k apologies but I'm going to close this because we're going to rewrite the UIs. Thanks again for your contribution!