-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DiffUtil #327
Added DiffUtil #327
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
What made you decide to use the AsyncListDiffer
rather than ListAdapter
?
name.text = questionnaireListItem.name | ||
description.text = questionnaireListItem.description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines seem wrong?
oldItem: QuestionnaireListItem, | ||
newItem: QuestionnaireListItem | ||
): Boolean { | ||
return oldItem.path == newItem.path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't belive this is correct. it's possible the same path can be used in two differnt items (not the least because of #244).
|
||
class ViewHolder(view: View) : RecyclerView.ViewHolder(view) { | ||
inner class ViewHolder(view: View) : RecyclerView.ViewHolder(view) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why inner?
Is this still being worked on? If not please close this PR. |
please feel free to reopen. |
Hey, I have added DiffUtil in QuestionnaireListAdapter to improve performance at later stages.