Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy nested items to childless answers #2600

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Jul 5, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2590

Description
At the moment we are copying nested items to answers with nested items. This would wipe out any existing answers to nested questions.

This PR makes sure we only copy nested items to new answers. It also improves documentation significantly and adds tests.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 enabled auto-merge (squash) July 8, 2024 17:09
@jingtang10 jingtang10 disabled auto-merge July 9, 2024 08:47
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 enabled auto-merge (squash) July 9, 2024 12:17
@jingtang10 jingtang10 merged commit 2e06cb2 into google:master Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Repeated Group: Anomalous behaviour of enableWhen expressions in a repeated group
3 participants