Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old plan generation APIs #2587

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Jun 24, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Delete deprecated old plan generation APIs in favour of new ones with optional parameters. This makes updating to the latest version of CQL stack easier.

Deprecated APIs to delete:

FhirOperator.generateCarePlan(String,String): IBaseResource
FhirOperator.generateCarePlan(String,String,String): IBaseResource
FhirOperator.generateCarePlan(CanonicalType,String,String? = null,String? = null,String? = null,IBaseDatatype? = null,IBaseDatatype? = null,IBaseDatatype? = null,IBaseDatatype? = null,IBaseDatatype? = null,IBaseParameters? = null,Boolean? = null,IBaseBundle? = null,IBaseParameters? = null): IBaseResource

All merged into the same API.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "deprecate" do you mean remove ? The deprecated APIs are being removed. Is that intended ?

@jingtang10 jingtang10 changed the title Deprecate old plan generation APIs Remove old plan generation APIs Jun 25, 2024
@jingtang10 jingtang10 enabled auto-merge (squash) June 25, 2024 11:44
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jingtang10 jingtang10 merged commit ada0b03 into google:master Jun 25, 2024
4 checks passed
@jingtang10 jingtang10 deleted the care-plan branch June 25, 2024 12:47
santosh-pingle pushed a commit to santosh-pingle/android-fhir that referenced this pull request Jul 8, 2024
* Deprecate old plan generation APIs

* Rename params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants