Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for custom widget #2580

Merged
merged 15 commits into from
Jun 25, 2024
Merged

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Jun 20, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2581

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@MJ1998 MJ1998 changed the title update readme according to review comments Update documentation for custom widget Jun 20, 2024
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks jajoo! this is really great!

mostly some formatting nitpicks re capitalisation and punctuation.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jajoo making more changes. pls let me know when ready.

@MJ1998 MJ1998 merged commit eb563f6 into google:master Jun 25, 2024
4 checks passed
santosh-pingle pushed a commit to santosh-pingle/android-fhir that referenced this pull request Jul 8, 2024
* update readme according to review comments

* remove extra sub-header

* remove extra

* recommend to try catalog app in action

* add catalog app link

* improve documentation

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

* Update docs/use/SDCL/Customize-how-a-Questionnaire-is-displayed.md

Co-authored-by: Jing Tang <[email protected]>

---------

Co-authored-by: Jing Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Update documentation for custom ui components
2 participants