Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty repeated group header. #2574

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #726

Description
In paginated layout, empty repeated group header was shown.

issue :
It was creating empty answer component for repeated group item while packing repeated group header.
fix :

  1. do not create empty response item component for repeated group header.
  2. do not filter empty answer component for repeated group

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2024-06-18.at.4.35.58.PM.mov

@santosh-pingle santosh-pingle marked this pull request as ready for review June 18, 2024 12:05
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @santosh-pingle for this

i think we can merge this to fix the issue at hand, but i'd like to triage the usage of the function createQuestionnaireResponseItem

@jingtang10 jingtang10 enabled auto-merge (squash) June 18, 2024 16:03
@jingtang10 jingtang10 merged commit ae8c9bb into google:master Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Handle repeated groups
2 participants