-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoassign android-fhir-reviewers@ instead of all of android-fhir@ as reviewers of PRs #2536
Conversation
… reviewers of PRs (fixes #2320)
@omarismail94 it says that you are the Maintainer of https://github.com/orgs/google/teams/android-fhir-reviewers - would you be able to make it publicly visible and ensure its members have write access to this repo? (Perhaps you could even make it a child team of https://github.com/orgs/google/teams/android-fhir ?) |
Pro Memoria: This error message, somewhat confusingly, does NOT appear as a (green) "Check", but is only visible directly in the Files changed tab on the
@omarismail94 has removed himself and made me a co-Maintainer of https://github.com/orgs/google/teams/android-fhir-reviewers, so I now have access to https://github.com/orgs/google/teams/android-fhir-reviewers/edit (but not to https://github.com/orgs/google/teams/android-fhir and https://github.com/orgs/google/teams/android-fhir-1).
That's the case now, https://github.com/orgs/google/teams/android-fhir-reviewers/edit says that @android-fhir-reviewers has "Team visibility: Visible (Recommended) = A visible team can be seen and @mentioned by every member of this organization."
Neither https://github.com/google/android-fhir/settings nor https://github.com/orgs/google/teams/android-fhir-reviewers/edit directly allowed me to that. I think we would have to add |
No, a better option than doing it like that is actually to make @google/android-fhir-reviewers a child team of @google/android-fhir ... I can and just did do this; this granted the @google/android-fhir-reviewers the Maintain role for https://github.com/google/android-fhir/ and the Write role for https://github.com/google/fhir-app-examples (just like all members of @google/android-fhir) have - which (to me) makes perfect sense!
@jingtang10 is currently the only Maintainer of @google/android-fhir, and would need to approve that request... until he has a chance to do so, I've (for at least temporarily) attempted to after all manually directly add @google/android-fhir to https://github.com/orgs/google/teams/android-fhir-reviewers/repositories... but I can't do that either, because "Only repositories that you have admin privileges for can be added."... 🤣 PS: Just FTR, for some reason there is both a @google/android-fhir and a @google/android-fhir-1 group; I've used the former here, and ignored the latter. (They both have the same members, currently - the |
…viewers of PRs This initial list matches https://github.com/orgs/google/teams/android-fhir-reviewers. We were not able to get @google/android-fhir-reviewers working; see #2536 for background. See #2320 for overall motivation.
I'm planning to close this PR in favour of #2545 if we merge that one... |
…viewers of PRs (#2545) This initial list matches https://github.com/orgs/google/teams/android-fhir-reviewers. We were not able to get @google/android-fhir-reviewers working; see #2536 for background. See #2320 for overall motivation.
Fixes #2320