Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Hidden Previous Button in Review Mode #2523

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

nsabale7
Copy link
Collaborator

@nsabale7 nsabale7 commented Apr 23, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2516

Description
Issue was constraints applied to the buttons.
Initial Constraints :
[Prev] -> [Next] -> [Submit] [Review]
So if submit and next button becomes invisible, prev was hiding below review

Current Constraints :
[Prev] -> [Next] -> [Review] -> [Submit]

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@nsabale7
Copy link
Collaborator Author

Recording.2024-04-23.104050.mp4
Recording.2024-04-23.104330.mp4

Copy link
Collaborator

@LZRS LZRS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nsabale7

@santosh-pingle santosh-pingle merged commit 56339b4 into google:master Apr 24, 2024
4 checks passed
icrc-fdeniger pushed a commit to icrc-fdeniger/android-fhir that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Previous button invisible when launched in review mode
3 participants