Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KM: Use resourcetype when searching by url #2518

Merged
merged 3 commits into from
May 9, 2024
Merged

KM: Use resourcetype when searching by url #2518

merged 3 commits into from
May 9, 2024

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Apr 18, 2024 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2490

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@MJ1998 MJ1998 marked this pull request as ready for review April 24, 2024 07:05
@MJ1998 MJ1998 requested review from santosh-pingle and a team as code owners April 24, 2024 07:05
@MJ1998 MJ1998 requested a review from kevinmost April 24, 2024 07:05
aditya-07
aditya-07 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, otherwise LGTM. Feel free to merge once you have resolved the comments.

knowledge/src/test/java/com/google/android/fhir/knowledge/KnowledgeManagerTest.kt Show resolved Hide resolved
knowledge/src/test/java/com/google/android/fhir/knowledge/KnowledgeManagerTest.kt Show resolved Hide resolved
@MJ1998 MJ1998 enabled auto-merge (squash) May 9, 2024 12:47
@MJ1998 MJ1998 merged commit 67c9529 into google:master May 9, 2024
4 checks passed
icrc-fdeniger pushed a commit to icrc-fdeniger/android-fhir that referenced this pull request May 9, 2024
@MJ1998 @icrc-fdeniger
KM: Use resourcetype when searching by url (google#2518)
b5ec256 
* Use resourcetype when searching by url

* Add tests for km loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-07 aditya-07 aditya-07 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle santosh-pingle is a code owner

@kevinmost kevinmost Awaiting requested review from kevinmost kevinmost was automatically assigned from google/android-fhir

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knowledge Manager uses the name instead of URL to fetch resources
3 participants
@MJ1998 @aditya-07 @android-fhir-bot