-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial new website (see #2232) #2513
Conversation
I've finally had a moment to have a closer look into why as-is this "works for me" (local), but initially fails the CI build: It's because I could just add https://pipenv.pypa.io/en/latest/installation.html to Looking around a bit, discarding a few repos with 0 stars, I have zoomed in on:
Of these, the last one (@palewire's) does both Python & PipEnv, and seem to do some caching; so I'll try to add that... |
https://github.com/palewire/install-python-pipenv-pipfile didn't seem to immediately just work, see palewire/install-python-pipenv-pipfile#7, so 'm trying https://github.com/tiagovrtr/actions-pipenv instead, let's see... |
That seems to work better, but
so trying Python 3.11 instead of latest 3.12 which I've initially selected (whatever works). |
14f7f8b
to
b40402d
Compare
That helped! Plus adding a missing install - I must have done that locally, but CI needs to explicitly do it as well, of course. With that, this is ready for review! https://google.github.io/android-fhir/ should look very different after this is merged... |
…-localized-plugin for website generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add initial new website (see google#2232) * Add mkdocs-minify-plugin to website generation * Pinned versions in Pipfile * Add mkdocs-git-revision-date-plugin to website generation * Replace mkdocs-git-revision-date-plugin with mkdocs-git-revision-date-localized-plugin for website generation
see #2232