Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial new website (see #2232) #2513

Merged
merged 5 commits into from
May 6, 2024
Merged

Add initial new website (see #2232) #2513

merged 5 commits into from
May 6, 2024

Conversation

vorburger
Copy link
Member

see #2232

@vorburger vorburger requested review from santosh-pingle and a team as code owners April 17, 2024 15:23
@vorburger vorburger requested a review from yigit April 17, 2024 15:23
@vorburger
Copy link
Member Author

I've finally had a moment to have a closer look into why as-is this "works for me" (local), but initially fails the CI build:

It's because build-docs.bash uses a pipenv - which is not available by default in GitHub Runner VM images, apparently.

I could just add https://pipenv.pypa.io/en/latest/installation.html to build-docs.bash ... or is there a ready-made action?

Looking around a bit, discarding a few repos with 0 stars, I have zoomed in on:

  1. https://github.com/tiagovrtr/actions-pipenv
  2. https://github.com/VaultVulp/action-pipenv
  3. https://github.com/palewire/install-python-pipenv-pipfile

Of these, the last one (@palewire's) does both Python & PipEnv, and seem to do some caching; so I'll try to add that...

@vorburger
Copy link
Member Author

@vorburger
Copy link
Member Author

I'm trying https://github.com/tiagovrtr/actions-pipenv instead, let's see...

That seems to work better, but pipenv run mkdocs build now fails with:

Warning: Python 3.11 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path/to/python
Error: Process completed with exit code 1.

so trying Python 3.11 instead of latest 3.12 which I've initially selected (whatever works).

@vorburger vorburger force-pushed the docs1 branch 2 times, most recently from 14f7f8b to b40402d Compare May 2, 2024 16:23
@vorburger
Copy link
Member Author

vorburger commented May 2, 2024

so trying Python 3.11 instead of latest 3.12 which I've initially selected (whatever works).

That helped! Plus adding a missing install - I must have done that locally, but CI needs to explicitly do it as well, of course.

With that, this is ready for review! https://google.github.io/android-fhir/ should look very different after this is merged...

.github/workflows/build.yml Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MJ1998 MJ1998 enabled auto-merge (squash) May 6, 2024 11:05
@MJ1998 MJ1998 merged commit a7ae309 into master May 6, 2024
4 checks passed
@MJ1998 MJ1998 deleted the docs1 branch May 6, 2024 11:20
icrc-fdeniger pushed a commit to icrc-fdeniger/android-fhir that referenced this pull request May 9, 2024
* Add initial new website (see google#2232)

* Add mkdocs-minify-plugin to website generation

* Pinned versions in Pipfile

* Add mkdocs-git-revision-date-plugin to website generation

* Replace mkdocs-git-revision-date-plugin with mkdocs-git-revision-date-localized-plugin for website generation
@vorburger vorburger mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants