-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark many things as internal #2494
Conversation
Switching to draft, I'm finding a lot of other things that appear to be safely marked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santosh-pingle can you run the demo app and just check that the db is functioning as expected (don't need to spend too much time)
@aditya-07 in case you spot anything wrong here.
thanks @williamito this is fine by me as long as tests pass - nothing glaringly wrong to me.
After this pull request was updated with the latest code changes (PR#2497), the upload sync was working fine, and the database was not throwing any exceptions. |
thanks so much santosh for testing! |
engine/src/main/java/com/google/android/fhir/sync/remote/FhirConverterFactory.kt
Outdated
Show resolved
Hide resolved
trying to fix this:
|
Description
Mark many things as internal, as they don't seem to be used by any public API. This will significantly streamline generated documentation.
Type
Code Health
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.