Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs/ API doc #2484

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Remove docs/ API doc #2484

merged 3 commits into from
Mar 25, 2024

Conversation

vorburger
Copy link
Member

It's removed because this will be generated during the build with #2483, as part of #2232.

@jingtang10 OK for you?

@vorburger vorburger requested review from santosh-pingle and a team as code owners March 16, 2024 01:11
@vorburger vorburger requested a review from yigit March 16, 2024 01:11
@vorburger
Copy link
Member Author

@jingtang10 or am I misunderstanding and you would want to keep these API docs from older releases? We could also do that, but if so, I need to move them.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for this!

@jingtang10
Copy link
Collaborator

@jingtang10 or am I misunderstanding and you would want to keep these API docs from older releases? We could also do that, but if so, I need to move them.

no this is great

@jingtang10 jingtang10 enabled auto-merge (squash) March 25, 2024 12:04
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (d1d0086) to head (6f71b74).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2484   +/-   ##
=========================================
  Coverage     65.56%   65.56%           
  Complexity     1006     1006           
=========================================
  Files           193      193           
  Lines          8396     8396           
  Branches       1507     1507           
=========================================
  Hits           5505     5505           
  Misses         2267     2267           
  Partials        624      624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jingtang10 jingtang10 merged commit 219e3b6 into master Mar 25, 2024
6 checks passed
@jingtang10 jingtang10 deleted the rm-docs branch March 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants