Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the bottom navigation container if there are no visible buttons. #2453

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2446

Description
If there is no button visible in the bottom navigation container then it was overlapping review mode recyclerview, as result screen was appearing blank.
Now issue is fixed by hiding bottomNavigation container if there is no children.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix
Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle changed the title Hide bottomnavigation container if no buttons are visible. Hide the bottom navigation container if there are no visible buttons. Feb 27, 2024
@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2024-02-27.at.17.42.34.mov

@santosh-pingle santosh-pingle marked this pull request as ready for review February 28, 2024 05:27
@santosh-pingle santosh-pingle requested a review from a team as a code owner February 28, 2024 05:27
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @santosh-pingle for the change!

as discussed, can you please explore ways to fix this issue in the layout xml files? that would be preferred over a fix in the kotlin code - at the end of the day, i feel it's more natural for the bottom navigation to collapse organically when no button is visible inside of it - this makes our code a bit simpler.

thanks!

@santosh-pingle
Copy link
Collaborator Author

Screenshot 2024-03-12 at 18 33 51 Screenshot 2024-03-12 at 18 10 25 Screenshot 2024-03-12 at 18 10 06 Screenshot 2024-03-12 at 18 09 56

@jingtang10 jingtang10 merged commit 4742e60 into google:master Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug Report: datacapture 1.1.0 - read-only mode renders empty questionnaire fragment
3 participants