Failing Test Case has been Corrected Now #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhammadSalman-7214
requested review from
deepankarb,
jingtang10,
joiskash,
pankajkatoch and
yigit
as code owners
jingtang10
requested changes
Feb 18, 2021
| assertThat(answer[0].value?.quantity?.value) | ||
| .isEqualTo(Decimal.newBuilder().setValue("10").build()) | ||
| assertThat(answer[0].value?.quantity?.value?.value) | ||
| .isEqualTo("10.0") |
There was a problem hiding this comment.
move to the line above
There was a problem hiding this comment.
you are saying that I move line 137 to merge with 136 or move both 136 and 137 lines to merge with line 135?
There was a problem hiding this comment.
No I'm saying you don't need a new line. This can be on the same line as the previous line.
|
Hi @MuhammadSalman-7214 thanks for the fix. I have incorporated your change in #248 which was submitted last night to fix the build. I'll close this PR for now. |
|
ok great @jingtang10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.