Loading workerContext using the Knowledge manager #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nsabale7 just a question about the worker-context. I'm not sure why we created two different worker-context.
It shouldn't be one? and where the loadWorkerContext method is being called? |
|
joiskash
suggested changes
Mar 5, 2024
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Show resolved
Hide resolved
...e/src/main/java/com/google/android/fhir/datacapture/mapping/StructureMapExtractionContext.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
|
fyi left a comment in the issue: #2448 (comment) i think we need to resolve this before we can merge this pr |
|
@joiskash @owais-vd @dubdabasoduba @jingtang10 I have added test using outbreak package. Please review this PR. |
MJ1998
reviewed
Apr 8, 2024
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Outdated
Show resolved
Hide resolved
MJ1998
approved these changes
Apr 18, 2024
MJ1998
reviewed
Apr 18, 2024
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2448
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.