-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for optionExclusive Extension in Popup #2438
Added Support for optionExclusive Extension in Popup #2438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @asad-zaman
I think the solution is correct. I am just wondering if the number of options too huge then submitSelectedChange function should be optimized by tracking the items that are currently selected.
In the meantime, can you also add a testcase to verify the changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes above!
Hi @MJ1998, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please UTs to handle the two conditions described below:
- What happens if there are more than one option exclusive answer options eg: "No Problem", "Not Valid"
- What happens if there are "Other" rows already added and you click on option exclusive answer? eg: Open choice question with other options added.
Hi @joiskash, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc: @jingtang10
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Hi @jingtang10, |
HI @jingtang10, |
Hi @jingtang10, |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2436
Description
Add
optionExclusive
extension support foranswerOption
in Popup for more than 10 items.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.