Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UploadStrategy.AllChangesBundlePut option from engine. #2431

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

aditya-07
Copy link
Collaborator

@aditya-07 aditya-07 commented Feb 6, 2024

As per the Fhir http rules, a Bundle transaction with multiple operations on the same resource can be rejected by the FHIR server. So removing the UploadStrategy.AllChangesBundlePut option as it may result in a Bundle with multiple updates on a same resource .

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

… same resource can be rejected by the FHIR server. So removing the UploadStrategy.AllChangesBundlePut option.
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jingtang10 jingtang10 merged commit 12a1b9b into google:master Feb 6, 2024
3 checks passed
@MJ1998
Copy link
Collaborator

MJ1998 commented Feb 6, 2024

Should we also not remove AllChangesBundlePost ?
@aditya-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants