Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unknown risk status color value. #2416

Closed

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
The current unknown status color value is white, which matches the background color of the patient list item. As a result, it fails to display any unknown risk status on the patient list, causing extra space just before the item. The unknown risk status color has been updated to ensure visibility.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

image

With fix
Screenshot 2024-01-31 at 13 34 39

@santosh-pingle santosh-pingle marked this pull request as ready for review January 31, 2024 09:28
@santosh-pingle santosh-pingle requested a review from a team as a code owner January 31, 2024 09:28
@santosh-pingle santosh-pingle linked an issue Jan 31, 2024 that may be closed by this pull request
@jingtang10
Copy link
Collaborator

please make these changes directly in #2414

@jingtang10 jingtang10 closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Demo app reskinning.
2 participants