Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the text during the re-bind of the Decimal and Integer view holders. #2403

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2401

Description
Updated the code to

  1. Set the draft answer correctly.
  2. Clear the answers when possible rebind occurs ( no draft or answer is available to be set).

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@aditya-07 aditya-07 enabled auto-merge (squash) January 9, 2024 08:28
@aditya-07 aditya-07 merged commit 3260a1e into google:master Jan 9, 2024
3 checks passed
hugomilosz pushed a commit to hugomilosz/android-fhir that referenced this pull request Jan 17, 2024
…olders. (google#2403)

* Set the draft value and clear the text when answer values are not there

* Review comments: Refactored code and tests
sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
…olders. (google#2403)

* Set the draft value and clear the text when answer values are not there

* Review comments: Refactored code and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

There is a duplicated invalid decimal entry in another decimal field.
3 participants