Add enablement operators EQUALS and NOT_EQUAL_TO #239

pld · 2021-02-14T03:02:53Z

Closes #236

Based on Valueset-questionnaire-enable-operator EQUALS is true if any answers contain the enableWhen answer. The definition of Not Equals is oddly worded, coded as NOT_EQUAL_TO is the negation of EQUALS.

google-cla · 2021-02-14T03:03:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pld · 2021-02-14T03:03:46Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ responseItem: QuestionnaireResponse.Item,
+ enableWhen: Questionnaire.Item.EnableWhen
+ ) =
+ responseItem.answerList.map { it.value.toByteString() }.contains(


Is there a better way to equality? values with the same content are not equal

hm I think this doesn't equal because they're different classes (Questionnaire.Item.EnableWhen.AnswerX and QuestionnaireResponse.Item.Answer.ValueX)... The right way of doing this probably write a utility function to compare each data type (since we don't actually know the type here). I'm happy for that to be a follow-up (or just create an issue)

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

jingtang10

Thanks Peter for your contribution 👍 just a couple of high-level comments. Haven't looked through the tests yet.

jingtang10 · 2021-02-14T12:48:35Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ */
+ private fun responseItemContainsAnswer(
+ responseItem: QuestionnaireResponse.Item,
+ enableWhen: Questionnaire.Item.EnableWhen


feels like this function signature can be tighter with the answer field in enableWhen rather than enableWhen itself.

jingtang10 · 2021-02-14T13:12:01Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

@@ -105,7 +105,24 @@ internal object EnablementEvaluator {
 return when (val operator = enableWhen.operator.value) {
 QuestionnaireItemOperatorCode.Value.EXISTS ->
 (responseItem.answerCount > 0) == enableWhen.answer.boolean.value
+ QuestionnaireItemOperatorCode.Value.EQUALS ->
+ responseItemContainsAnswer(responseItem, enableWhen)


Looking at rest of the opeartors: https://www.hl7.org/fhir/valueset-questionnaire-enable-operator.html it probably would make a lot of sense to provide some kind of predicate function here.

so you'd have in here:

responseItem.contains(enableWhen.operator.toPredicate())

and then have two extension functions.

the first extension function converts an enable when operator to a predicate

private fun Questionnaire.Item.EnableWhen.OperatorCode.toPredicate(): (QuestionnaireResponse.Item.Answer) -> Boolean { ... }

and the second extension function takes that predicate to figure out if any answer in the answer list in the response item satisfies that predicate:

private fun QuestionnaireResponse.Item.contains(predicate:(QuestionnaireResponse.Item.Answer) -> Boolean) { ... }

I think as a result this when block will be moved to the toPredicate extension function, and the code in this function will be simplified.

jingtang10 · 2021-02-14T13:19:07Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ responseItem: QuestionnaireResponse.Item,
+ enableWhen: Questionnaire.Item.EnableWhen
+ ) =
+ responseItem.answerList.map { it.value.toByteString() }.contains(


hm I think this doesn't equal because they're different classes (Questionnaire.Item.EnableWhen.AnswerX and QuestionnaireResponse.Item.Answer.ValueX)... The right way of doing this probably write a utility function to compare each data type (since we don't actually know the type here). I'm happy for that to be a follow-up (or just create an issue)

google-cla · 2021-02-14T20:10:33Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pld · 2021-02-14T20:11:12Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

- else -> throw NotImplementedError("Enable when operator $operator is not implemented.")
- }
+ return if (QuestionnaireItemOperatorCode.Value.EXISTS == enableWhen.operator.value)
+ (responseItem.answerCount > 0) == enableWhen.answer.boolean.value else


this operator seems like a special case

would it work if you just have a

{ enableWhen.answer.boolean.value }

So a predicate that would always return true for any answer item if the enableWhen.answer.boolean.value is true. And one that always returns false for any answer item if the enableWhen.aswer.boolean.value is false.

ah yea, so I had tried that, unless I'm missing something the issue is the evaluate_expectsNoAnswer_answerDoesNotExist_shouldReturnTrue test case where enable when exists is set to false and there are no answer, this should return true, but because there are no answers it will return false.

hm. yeah. damn. 😛

nit: can you please just reformat this a little bit

return if (...) { ... } else { ... }

pld · 2021-02-14T20:14:48Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+/**
+ * Returns a predicate based on the `EnableWhen` `operator` and `Answer` value.
+ */
+private fun Questionnaire.Item.EnableWhen.toPredicate(): (QuestionnaireResponse.Item.Answer)


because the predicate depends on the value of the EnableWhen.Answer, I wrote this extending EnableWhen instead of EnableWhen.operator. This could take the answer as an additional argument, hmm maybe there's a way to clean this up

pld · 2021-02-14T20:19:03Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ when (val operator = this.operator.value) {
+ QuestionnaireItemOperatorCode.Value.EQUALS ->
+ return {
+ this.answer.toByteString() == it.value.toByteString()


Kinda suspicious, I'm sure I'm missing a better way with the similarity here to line 123.

I looked a bit at how to write the type aware comparisons, having this return only the operator could help to remove the need for the answer here (but then the answer would need to be passed to contains I think) and the type aware comparisons could go in contains, using the operator.

Or, and probably better, have a helper here that takes the operator and the answer, then runs the type aware comparisons

google-cla · 2021-02-15T04:03:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-02-15T04:05:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-02-15T15:12:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pld · 2021-02-15T15:14:54Z

datacapture/src/main/java/com/google/android/fhir/datacapture/ValueForType.kt

@@ -0,0 +1,52 @@
+package com.google.android.fhir.datacapture


is there better name for this file? not sure how best to name structure in kotlin projects

Yeah in Kotlin you typically do More*s.kt for utilities. So maybe MoreQuestionnaireItemTypes.kt? I feel it's ok to keep these two in the same class even though one is about questionnaire item and the other is about questionnaire response item.

google-cla · 2021-02-15T15:21:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jingtang10

Thanks Peter!

jingtang10 · 2021-02-15T15:26:23Z

datacapture/src/main/java/com/google/android/fhir/datacapture/ValueForType.kt

@@ -0,0 +1,52 @@
+package com.google.android.fhir.datacapture


Yeah in Kotlin you typically do More*s.kt for utilities. So maybe MoreQuestionnaireItemTypes.kt? I feel it's ok to keep these two in the same class even though one is about questionnaire item and the other is about questionnaire response item.

jingtang10 · 2021-02-15T15:28:19Z

datacapture/src/main/java/com/google/android/fhir/datacapture/ValueForType.kt

+ * TODO: move to a shared library with QuestionnaireResponse.Item.Answer.getValueForType
+ * Returns the value of the [Questionnaire.Item.EnableWhen.AnswerX] for the [type].
+ *


jingtang10 · 2021-02-15T15:39:22Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ } catch (exception: IllegalArgumentException) {
+ this.answer.toByteString()
+ }


I feel slightly uneasy about swallowing an error this way. Can we just throw?

same below

yea sounds good, will update the tests to set the questionnaire item type and remove

jingtang10 · 2021-02-15T15:50:49Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ *
+ * @param type used to get value based on [Questionnaire.Item.TypeCode].
+ */
+private fun Questionnaire.Item.EnableWhen.toPredicate(type: Questionnaire.Item.TypeCode):


thanks for the comment i think you're right here about not putting the extension function on the operator and my initial suggestion was probably misleading. also seems kinda strange to me to actually have to have the type as a param. on 2nd thought perhaps this isn't really meant to be an extension function after all? happy for this to be a just private utility function. what do you think?

jingtang10 · 2021-02-15T15:55:07Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

- else -> throw NotImplementedError("Enable when operator $operator is not implemented.")
- }
+ return if (QuestionnaireItemOperatorCode.Value.EXISTS == enableWhen.operator.value)
+ (responseItem.answerCount > 0) == enableWhen.answer.boolean.value else


would it work if you just have a

{ enableWhen.answer.boolean.value }

So a predicate that would always return true for any answer item if the enableWhen.answer.boolean.value is true. And one that always returns false for any answer item if the enableWhen.aswer.boolean.value is false.

jingtang10 · 2021-02-15T18:03:37Z

...ture/src/test/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluatorTest.kt

+ }
+
+ @Test
+ fun evaluate_expectsAnswer_answerEqualOne_shouldReturnTrue() {


the way i think about these test cases is that: we'll cover each operator in positive and negative cases, and then we'll have some tests that cover cases with multiple answers regardless of operators. having these cases is fine, but i kinda feel they'll really make the number of test cases explode without improving test coverage (since all cases should already have been hit).

as an example: we also have the ANY / OR enable when behaviors, does it mean the number of tests cases will x2? I don't think that'd be manageable.

google-cla · 2021-02-15T21:04:11Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-02-15T21:07:30Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jingtang10

🎉🎉🎉

approved. just a few nits. thanks again peter!

jingtang10 · 2021-02-15T22:03:53Z

datacapture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemTypes.kt

+/**
+ * Returns the value of the [Questionnaire.Item.EnableWhen.AnswerX] for the [type].
+ *
+ * Used to retrieve the value to set the field in the extracted FHIR resource.


this line can be removed since it's now a utility function used for various things.

jingtang10 · 2021-02-15T22:04:01Z

datacapture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemTypes.kt

+/**
+ * Returns the value of the [QuestionnaireResponse.Item.Answer] for the [type].
+ *
+ * Used to retrieve the value to set the field in the extracted FHIR resource.


jingtang10 · 2021-02-15T22:05:51Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

- else -> throw NotImplementedError("Enable when operator $operator is not implemented.")
- }
+ return if (QuestionnaireItemOperatorCode.Value.EXISTS == enableWhen.operator.value)
+ (responseItem.answerCount > 0) == enableWhen.answer.boolean.value else


hm. yeah. damn. 😛

nit: can you please just reformat this a little bit

return if (...) { ... } else { ... }

jingtang10 · 2021-02-15T22:08:03Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ enableWhen: Questionnaire.Item.EnableWhen,
+ type: Questionnaire.Item.TypeCode
+):
+ (QuestionnaireResponse.Item.Answer) -> Boolean {


nit: this can be on the previous line

jingtang10 · 2021-02-15T22:18:10Z

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt

+ return {
+ val answerValue = it.getValueForType(type)
+ when (val operator = enableWhen.operator.value) {


i think the structure here should be changed. here a function closure is returned... and the branching of operator happens when the function closure predicate is called. in other words if you need to evaluate multiple answers, each time you check which operator and choose the correct comparison logic. that seems logically redundant and an (admitedly tiny tiny) performance penalty.

cool yea definitely makes sense to keep the closure tight, there's probably room later for a further refactor here to get rid of some redundancy, was looking at the compareTo function, but couldn't get to a better place, will push in

google-cla · 2021-02-15T23:07:30Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jingtang10 · 2021-02-15T23:08:39Z

i'm not sure this bot is working...

jingtang10 · 2021-02-15T23:09:50Z

it seems to think your email address is [email protected] for some reason...

pld · 2021-02-15T23:11:54Z

Oh yea that's correct w/the email privacy option on, let me turn it off and rebase my commits to add my email...

…e#222

google-cla · 2021-02-15T23:15:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pld · 2021-02-15T23:15:20Z

should be set to [email protected] now

googlebot · 2021-02-16T12:17:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jingtang10 · 2021-02-16T12:20:54Z

from what I can see [email protected] is still in the state of need_sender_cla... urg i'm so sorry about this faff. can you check again?

pld · 2021-02-17T17:01:24Z

@googlebot I signed it!

google-cla · 2021-02-17T17:01:46Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

pld requested review from deepankarb, jingtang10, joiskash, pankajkatoch and yigit as code owners February 14, 2021 03:02

pld commented Feb 14, 2021

View reviewed changes

datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt Outdated Show resolved Hide resolved

jingtang10 requested changes Feb 14, 2021

View reviewed changes

jingtang10 added this to In progress in Data capture library via automation Feb 14, 2021

jingtang10 assigned pld Feb 14, 2021

pld force-pushed the pl/enablement-operator-equals-not-equals branch from 758299e to 31e2990 Compare February 14, 2021 20:10

pld commented Feb 14, 2021

View reviewed changes

pld force-pushed the pl/enablement-operator-equals-not-equals branch from d2bd7ce to 451d977 Compare February 15, 2021 04:05

pld force-pushed the pl/enablement-operator-equals-not-equals branch from 451d977 to 25d33aa Compare February 15, 2021 15:11

pld commented Feb 15, 2021

View reviewed changes

pld force-pushed the pl/enablement-operator-equals-not-equals branch from 25d33aa to 23260d4 Compare February 15, 2021 15:21

jingtang10 requested changes Feb 15, 2021

View reviewed changes

pld force-pushed the pl/enablement-operator-equals-not-equals branch from dbb75e9 to 5dd7c4c Compare February 15, 2021 21:07

jingtang10 approved these changes Feb 15, 2021

View reviewed changes

pld added 13 commits February 15, 2021 18:14

add equals and test

c2e73d6

add tests for equals and not equals

7c04df3

add not equal to as not equals

bc5890b

correct indentation and formatting

e539bb6

add private fun docstring

07a4d09

use extension predicate and contains functions

316b1f3

pass type through and use getValueForType utility function from googl…

b8701b6

…e#222

move get value for type functions to their own file

de37584

rename to follow utility style

a5d4bbd

change predicate extension to utility function

97a97e6

set questionnaire item type, remove try catch, remove duplicate tests

335e1c0

push closure into when and format

296081e

remove incorrect notes

529880c

pld force-pushed the pl/enablement-operator-equals-not-equals branch from 1d1143e to 529880c Compare February 15, 2021 23:14

pld merged commit a16fee4 into google:master Feb 17, 2021

Data capture library automation moved this from In progress to Done Feb 17, 2021

pld deleted the pl/enablement-operator-equals-not-equals branch February 17, 2021 17:03

Tarun-Bhardwaj added the type:bug Something isn't working label Sep 27, 2021

Add enablement operators EQUALS and NOT_EQUAL_TO #239

Add enablement operators EQUALS and NOT_EQUAL_TO #239

Conversation

pld commented Feb 14, 2021

google-cla bot commented Feb 14, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingtang10 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Feb 14, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

jingtang10 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

jingtang10 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

jingtang10 commented Feb 15, 2021

jingtang10 commented Feb 15, 2021

pld commented Feb 15, 2021

google-cla bot commented Feb 15, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

pld commented Feb 15, 2021