-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor demo project #2348
Refactor demo project #2348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoangchungk53qx1
Thanks for your first PR. Looking forward for more PRs from you.
Why do you wanna split the pollState into periodic and oneTime ?
demo/src/main/java/com/google/android/fhir/demo/extensions/LifeCycleExt.kt
Show resolved
Hide resolved
Looks good🙏 @hoangchungk53qx1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks chung for the contribution. i think this change does make sense and will approve now.
in the future, can you please try to use more descriptive names for prs and perhaps send more specific changes (for example in this case splitting the flow into 2 can be a separate pr, and adding the file utility can be another).
but all in all very good. thanks for the pr again! look forward to receiving more contributions from you.
I just made a few changes to this PR, thank you ! |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
refactor demo project.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.