Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor demo project #2348

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Refactor demo project #2348

merged 16 commits into from
Feb 27, 2024

Conversation

hoangchungk53qx1
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
refactor demo project.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • [v] I have read and acknowledged the Code of conduct.
  • [v] I have read the Contributing page.
  • [v] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • [v] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • [v] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • [v] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • [v] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@hoangchungk53qx1
Copy link
Contributor Author

@jingtang10 👆

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoangchungk53qx1
Thanks for your first PR. Looking forward for more PRs from you.

Why do you wanna split the pollState into periodic and oneTime ?

@hoc081098
Copy link

Looks good🙏 @hoangchungk53qx1

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks chung for the contribution. i think this change does make sense and will approve now.

in the future, can you please try to use more descriptive names for prs and perhaps send more specific changes (for example in this case splitting the flow into 2 can be a separate pr, and adding the file utility can be another).

but all in all very good. thanks for the pr again! look forward to receiving more contributions from you.

@hoangchungk53qx1
Copy link
Contributor Author

thanks chung for the contribution. i think this change does make sense and will approve now.

in the future, can you please try to use more descriptive names for prs and perhaps send more specific changes (for example in this case splitting the flow into 2 can be a separate pr, and adding the file utility can be another).

but all in all very good. thanks for the pr again! look forward to receiving more contributions from you.

I just made a few changes to this PR, thank you !

@jingtang10 jingtang10 enabled auto-merge (squash) February 26, 2024 13:17
@jingtang10 jingtang10 merged commit e06416c into google:master Feb 27, 2024
3 checks passed
@hoc081098
Copy link

@hoangchungk53qx1 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

5 participants