Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Version Catalog, initially intentionally only for Glide #2306

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

vorburger
Copy link
Member

see #2302

My expectation is that if this passes CI and gets merged, Dependabot will automagically propose a bump for Glide - let's try and see.

If this works, we should then migrate to this model. Perhaps that's something that could be "crowd sourced" and fanned out, instead of me doing all migrations myself?

PS: There would be an intermediate phase with "mixed" dependency declaration; to me such a "gradual adoption" is a "feature not a bug", with testing each change, and more sensible than a single big bang all in one migration.

@omarismail94
Copy link
Contributor

This is actually VERY nice!! I never knew about this:
https://docs.gradle.org/current/userguide/platforms.html

Superb job!

@omarismail94 omarismail94 enabled auto-merge (squash) October 26, 2023 18:53
@vorburger
Copy link
Member Author

Superb job!

🙇🏽 but credit where credit is due - I learnt about this after doing research starting from this comment!

https://docs.gradle.org/current/userguide/platforms.html

see #2302, also https://developer.android.com/build/migrate-to-catalogs, and https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/about-dependabot-version-updates#gradle for why "My expectation is that if this passes CI and gets merged, Dependabot will automagically propose a bump for Glide - let's try and see."

@jingtang10
Copy link
Collaborator

this is lovely. thanks @vorburger!

@jingtang10
Copy link
Collaborator

If this works, we should then migrate to this model. Perhaps that's something that could be "crowd sourced" and fanned out, instead of me doing all migrations myself? -> agreed.

@vorburger vorburger mentioned this pull request Dec 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants