Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Jackson versions in (only) buildscript from 2.15.2 to 2.15.3 #2301

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Bump Jackson versions in (only) buildscript from 2.15.2 to 2.15.3 #2301

merged 2 commits into from
Oct 26, 2023

Conversation

vorburger
Copy link
Member

This is better than #2283 and #2285.

@vorburger vorburger requested review from santosh-pingle and a team as code owners October 25, 2023 18:09
@vorburger vorburger requested a review from MJ1998 October 25, 2023 18:09
@vorburger vorburger added dependencies Pull requests that update a dependency file java Pull requests that update Java code P3 Low priority issue effort:xsmall Extra small effort - 1 day labels Oct 25, 2023
@vorburger vorburger mentioned this pull request Oct 25, 2023
Closed
@vorburger vorburger marked this pull request as draft October 25, 2023 19:20
@vorburger vorburger self-assigned this Oct 25, 2023
@vorburger vorburger marked this pull request as ready for review October 25, 2023 19:20
@vorburger vorburger removed their assignment Oct 25, 2023
This was referenced Oct 25, 2023
Closed
Closed
@vorburger vorburger marked this pull request as draft October 26, 2023 07:25
@vorburger
Copy link
Member Author

Please hold with reviewing and merging this; I'll try to do this differently (via #2302)...

@vorburger vorburger marked this pull request as ready for review October 26, 2023 10:05
@vorburger
Copy link
Member Author

Re-un-drafting this, following #2305, please do now review and merge this PR, as-is.

@vorburger
Copy link
Member Author

@aditya-07 re. @jingtang10 feedback on Chat that you may be working on something related, just to synchronize:

Can you point me to bug / PR that you are working on related to Jackson? This PR only does a minor version bump of the buildscript dependencies, if you are working on the runtime Jackson dependency versions (in https://github.com/google/android-fhir/blob/master/buildSrc/src/main/kotlin/Dependencies.kt), then this is unrelated and OK to merge as-is - LGTY?

@vorburger
Copy link
Member Author

@aditya-07 on Chat pointed out that the runtime (APK) dependencies class has comments related to jackson support on Android 24, which is our minimum supported version, so maybe bumping up Jackson version could end up breaking stuff.

However this PR only bumps the buildscript Jackson dependency versions, in settings.gradle.kts - which is a completely separate classpath scope.

To the best of my knowledge, given that this PR fully passes the build, this is safe to merge.

Please review?

aditya-07
aditya-07 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omarismail94 omarismail94 enabled auto-merge (squash) October 26, 2023 14:44
@vorburger vorburger changed the title Bump Jackson from 2.15.2 to 2.15.3 Bump Jackson versions in (only) buildscript from 2.15.2 to 2.15.3 Oct 26, 2023
@omarismail94 omarismail94 merged commit ee30854 into google:master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-07 aditya-07 aditya-07 approved these changes

@omarismail94 omarismail94 omarismail94 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@MJ1998 MJ1998 Awaiting requested review from MJ1998 MJ1998 was automatically assigned from google/android-fhir

Assignees

@aditya-07 aditya-07

Labels
dependencies Pull requests that update a dependency file effort:xsmall Extra small effort - 1 day java Pull requests that update Java code P3 Low priority issue
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vorburger @aditya-07 @omarismail94 @android-fhir-bot