Fixed bug with date and date time widgets where you cannot reenter without moving away #223
Conversation
|
This is excellent! Thanks for the fix! Can you just do the same in https://github.com/google/android-fhir/blob/master/datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt? I will approve after that. |
| @@ -127,6 +128,7 @@ object QuestionnaireItemDateTimePickerViewHolderFactory : QuestionnaireItemViewH | |||
| TimePickerFragment.TAG | |||
| ) | |||
| } | |||
| timeInputLayout.clearFocus() | |||
There was a problem hiding this comment.
I think this should be one line higher i.e. within the curly brackets?
There was a problem hiding this comment.
Yes, yes I realized the mistake. Changing it.
| @@ -102,6 +102,7 @@ object QuestionnaireItemDatePickerViewHolderFactory : QuestionnaireItemViewHolde | |||
| context.supportFragmentManager, | |||
| DatePickerFragment.TAG | |||
| ) | |||
| textInputLayout.clearFocus() | |||
There was a problem hiding this comment.
please add the following comment (or something similar) and add the same to the other two placess
| textInputLayout.clearFocus() | |
| // Clear focus so that the user can refocus to open the dialog | |
| textInputLayout.clearFocus() |
|
Please feel free to merge once the tests pass. |
|
@jingtang10 1 check is failing and I am not able to interpret the reason for it's failure. Can you check? |
|
tests passing now -- please feel free to merge your first PR! 🎉 |
|
Only those with write access to this repo can merge PRs. There doesn't seem to be an option for me to merge the PR. |
|
Merged it for you Varun -- and thanks again for your contribution. If you're looking to contribute regularly I will add you as a collaborator thanks! |
Sure, I'd love that. |
Fixes: #208