Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL to GitHub CI Action (fixes #2185) #2207

Merged

Conversation

vorburger
Copy link
Member

Fixes #2185 (hopefully, we'll see).

This is a variant of #2206, which was an alternative approach to #2204 & #2205 and the earlier #2027.

This take uses a very large VM (like #2198).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jingtang10
Copy link
Collaborator

have you seen this michael?

Screenshot 2023-10-02 at 19 49 11

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy for you to merge this to iterate, but please keep the issue open until code ql actually works well.

thanks so much for investigating @vorburger!

@omarismail94 omarismail94 enabled auto-merge (squash) October 6, 2023 10:56
@omarismail94 omarismail94 merged commit a9b685a into google:master Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Set up codeql
3 participants